On Thu, Jul 25, 2019 at 03:47:44PM -0300, Jason Gunthorpe wrote: > On Thu, Jul 25, 2019 at 11:37:37AM +0300, Kamal Heib wrote: > > On Mon, Jul 22, 2019 at 10:43:27AM -0300, Jason Gunthorpe wrote: > > > On Mon, Jul 22, 2019 at 10:05:47AM +0300, Kamal Heib wrote: > > > > This series includes three patches that add the support for reporting > > > > physical state for the cxgb3, cxgb4, and i40iw drivers via sysfs. > > > > > > > > Kamal Heib (3): > > > > RDMA/cxgb3: Report phys_state in query_port > > > > RDMA/cxgb4: Report phys_state in query_port > > > > RDMA/i40iw: Report phys_state in query_port > > > > > > > > drivers/infiniband/hw/cxgb3/iwch_provider.c | 16 +++++++++++----- > > > > drivers/infiniband/hw/cxgb4/provider.c | 16 +++++++++++----- > > > > drivers/infiniband/hw/i40iw/i40iw_verbs.c | 7 +++++-- > > > > 3 files changed, 27 insertions(+), 12 deletions(-) > > > > > > Lets not have this generic iwapr code open coded please. > > > > > > The core code already knows what the netdev is for the iWarp device. > > > > > > Jason > > > > I'm not sure if I truly understand what you are trying to say here. > > > > Could you please add more info? > > Implement this in the core code if the port type is iwarp OK, I'll give it a try. > > Jason