On 24/07/2019 22:03, Jason Gunthorpe wrote: > On Sun, Jul 07, 2019 at 05:20:38PM +0300, Gal Pressman wrote: >> Expose hardware statistics through the sysfs api: >> /sys/class/infiniband/efa_0/hw_counters/*. >> >> Reviewed-by: Firas JahJah <firasj@xxxxxxxxxx> >> Reviewed-by: Yossi Leybovich <sleybo@xxxxxxxxxx> >> Signed-off-by: Gal Pressman <galpress@xxxxxxxxxx> >> --- >> drivers/infiniband/hw/efa/efa.h | 3 + >> drivers/infiniband/hw/efa/efa_com_cmd.c | 35 +++++++++++ >> drivers/infiniband/hw/efa/efa_com_cmd.h | 23 +++++++ >> drivers/infiniband/hw/efa/efa_main.c | 2 + >> drivers/infiniband/hw/efa/efa_verbs.c | 79 +++++++++++++++++++++++++ >> 5 files changed, 142 insertions(+) > > Am I right that this patch needs > > https://patchwork.kernel.org/patch/11053949/ > > before it won't crash? That's right. I'm going to resubmit this patch regardless to remove the 'if (port_num)' check in efa_alloc_hw_stats as the exposed device stats are the same as the port stats (only port 1) and some userspace tools use the port stats. I'll make sure to note the patch dependency in v2.
