Pls ignore this, I will fix it. On 2019/7/24 11:44, YueHaibing wrote: > If INFINIBAND_HNS_HIP06 is selected and HNS_DSAF > is m, but INFINIBAND_HNS is y, building fails: > > drivers/infiniband/hw/hns/hns_roce_hw_v1.o: In function `hns_roce_v1_reset': > hns_roce_hw_v1.c:(.text+0x39fa): undefined reference to `hns_dsaf_roce_reset' > hns_roce_hw_v1.c:(.text+0x3a25): undefined reference to `hns_dsaf_roce_reset' > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Fixes: 08805fdbeb2d ("RDMA/hns: Split hw v1 driver from hns roce driver") > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> > --- > v2: use select instead of depends > --- > drivers/infiniband/hw/hns/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/hns/Kconfig b/drivers/infiniband/hw/hns/Kconfig > index b9dfac0..5f6d750 100644 > --- a/drivers/infiniband/hw/hns/Kconfig > +++ b/drivers/infiniband/hw/hns/Kconfig > @@ -12,7 +12,8 @@ config INFINIBAND_HNS > > config INFINIBAND_HNS_HIP06 > bool "Hisilicon Hip06 Family RoCE support" > - depends on INFINIBAND_HNS && HNS && HNS_DSAF && HNS_ENET > + depends on INFINIBAND_HNS && HNS && HNS_ENET > + select HNS_DSAF > ---help--- > RoCE driver support for Hisilicon RoCE engine in Hisilicon Hip06 and > Hip07 SoC. These RoCE engines are platform devices. >