On 22/07/2019 20:52, Leon Romanovsky wrote: > On Mon, Jul 22, 2019 at 06:10:01PM +0300, Gal Pressman wrote: >> Hi, >> >> I pulled the latest for-next branch (5.3-rc1) which includes the new stats stuff >> and applied a patch to enable EFA stats [1], and I'm getting the following trace >> [2]. The EFA patch isn't merged yet so it could cause some extra noise, but this >> did not happen before the core statistics patches were merged. >> >> From a quick look it seems that 'port_counter->hstats' is only initialized for >> ports 1..num_ports (i.e not initialized for port 0, device stats) in >> rdma_counter_init rdma_for_each_port loop. >> >> As a result, rdma_counter_get_hwstat_value hits a NULL pointer dereference when >> querying device statistics as it tries to access an uninitialized hstats field in: >> sum += port_counter->hstats->value[index]; >> >> I'm thinking of adding a check similar to the one that exists in >> counter_history_stat_update and return 0 in case of !port_counter->hstats. >> What do you guys think? > > It is in my queue, I waited for -rc1 to start sending. > > https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/commit/?h=rdma-next&id=32f6bc477e9432776d6938beeda1905198485f5e Thanks, good to know that it's the same fix.
