pci_alloc_consitent calls dma_alloc_coherent directly. In commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*"), dma_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang <huangfq.daxian@xxxxxxxxx> --- Changes in v3: - Use actual commit rather than the merge commit in the commit message drivers/infiniband/hw/nes/nes_verbs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/infiniband/hw/nes/nes_verbs.c b/drivers/infiniband/hw/nes/nes_verbs.c index 49024326a518..534f978f1a58 100644 --- a/drivers/infiniband/hw/nes/nes_verbs.c +++ b/drivers/infiniband/hw/nes/nes_verbs.c @@ -828,7 +828,6 @@ static int nes_setup_virt_qp(struct nes_qp *nesqp, struct nes_pbl *nespbl, kunmap(nesqp->page); return -ENOMEM; } - memset(nesqp->pbl_vbase, 0, 256); /* fill in the page address in the pbl buffer.. */ tpbl = pblbuffer + 16; pbl = (__le64 *)nespbl->pbl_vbase; @@ -898,8 +897,6 @@ static int nes_setup_mmap_qp(struct nes_qp *nesqp, struct nes_vnic *nesvnic, "host descriptor rings located @ %p (pa = 0x%08lX.) size = %u.\n", mem, (unsigned long)nesqp->hwqp.sq_pbase, nesqp->qp_mem_size); - memset(mem, 0, nesqp->qp_mem_size); - nesqp->hwqp.sq_vbase = mem; mem += sizeof(struct nes_hw_qp_wqe) * sq_size; -- 2.11.0