On Fri, 2019-07-12 at 10:57 +0200, Arnd Bergmann wrote: > Without CONFIG_MLX5_ESWITCH we get a harmless warning: > > drivers/net/ethernet/mellanox/mlx5/core/en_main.c:3467:21: error: > unused variable 'priv' [-Werror,-Wunused-variable] > struct mlx5e_priv *priv = netdev_priv(dev); > Hi Arnd, thanks for your patch, a similar patch that addresses this issue was already submitted and applied to net-next [1] [1] https://www.spinics.net/lists/netdev/msg585433.html > Hide the declaration in the same #ifdef as its usage. > > Fixes: 4e95bc268b91 ("net: flow_offload: add > flow_block_cb_setup_simple()") > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > --- > drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > index 6d0ae87c8ded..b562ba904ea1 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > @@ -3464,7 +3464,9 @@ static LIST_HEAD(mlx5e_block_cb_list); > static int mlx5e_setup_tc(struct net_device *dev, enum tc_setup_type > type, > void *type_data) > { > +#ifdef CONFIG_MLX5_ESWITCH > struct mlx5e_priv *priv = netdev_priv(dev); > +#endif > > switch (type) { > #ifdef CONFIG_MLX5_ESWITCH
