RE: [PATCH] [net-next] IB/hfi1: removed shadowed 'err' variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: RE: [PATCH] [net-next] IB/hfi1: removed shadowed 'err' variable
From: "Marciniszyn, Mike" <mike.marciniszyn@xxxxxxxxx>
Date: Wed, 10 Jul 2019 16:54:33 +0000
Accept-language: en-US
Cc: "Arumugam, Kamenee" <kamenee.arumugam@xxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxxxxxx>, Shamir Rabinovitch <shamir.rabinovitch@xxxxxxxxxx>, "Gal Pressman" <galpress@xxxxxxxxxx>, Leon Romanovsky <leon@xxxxxxxxxx>, "linux-rdma@xxxxxxxxxxxxxxx" <linux-rdma@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "clang-built-linux@xxxxxxxxxxxxxxxx" <clang-built-linux@xxxxxxxxxxxxxxxx>
Dlp-product: dlpe-windows
Dlp-reaction: no-action
Dlp-version: 11.0.600.7
In-reply-to: <20190710130802.1878874-1-arnd@arndb.de>
References: <20190710130802.1878874-1-arnd@arndb.de>

> Subject: [PATCH] [net-next] IB/hfi1: removed shadowed 'err' variable
> 
> I can't think of any reason for the inner variable declaration, so
> remove it to avoid the issue.
> 

I agree!

> Fixes: 239b0e52d8aa ("IB/hfi1: Move rvt_cq_wc struct into uapi directory")

Thanks for catching this!

Acked-by: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx>

Follow-Ups:
- Re: [PATCH] [net-next] IB/hfi1: removed shadowed 'err' variable
  - From: Jason Gunthorpe

References:
- [PATCH] [net-next] IB/hfi1: removed shadowed 'err' variable
  - From: Arnd Bergmann

Prev by Date: Re: [PATCH v4 00/25] InfiniBand Transport (IBTRS) and Network Block Device (IBNBD)
Next by Date: Re: [PATCH] [net-next] IB/hfi1: removed shadowed 'err' variable
Previous by thread: [PATCH] [net-next] IB/hfi1: removed shadowed 'err' variable
Next by thread: Re: [PATCH] [net-next] IB/hfi1: removed shadowed 'err' variable
Index(es):
- Date
- Thread

[Index of Archives] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Photo] [Yosemite News] [Yosemite Photos] [Linux Kernel] [Linux SCSI] [XFree86]