On Tue, Jul 09, 2019 at 03:38:57PM -0700, Nick Desaulniers wrote: > On Tue, Jul 9, 2019 at 3:13 PM Nathan Chancellor > <natechancellor@xxxxxxxxx> wrote: > > > > clang warns: > > > > drivers/infiniband/sw/rdmavt/cq.c:260:7: warning: variable 'err' is used > > Oh, !$*@, this is a tricky one. While the if scoped `err` declared on > L250 is initialized when used at L260, the function scoped `err` > declared on L211 is not initialized when it is used on L310 when > control flow enters the if on L249 then the goto on L255 or L261. So > this is a bug due to the if scoped `err` "shadowing" the function > scoped `err`. > > Maybe not important enough to send a v2, but I feel like the commit > message should say something along the lines of `fix a potential use > of uninitialized memory due to shadowing`. Either way, this fixes a > real bug, so thanks for the patch. > Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> Gah, shadowing was the word I was looking for. Knew the behavior, didn't remember what it was called. I like the clarity of your explanation better so I will clean up the message and send a v2 shortly with your reviewed by. Thanks for the review! Nathan
