On Sun, Jun 30, 2019 at 04:48:41PM +0300, Leon Romanovsky wrote: > From: Valentine Fatiev <valentinef@xxxxxxxxxxxx> > > Despite failure in ipoib_dev_init() we continue with initialization > flow and creation of child device. It causes to the situation > where this child device is added too early to parent device list. > > change the logic, so in case of failure we properly return error > from ipoib_dev_init() and add child only in success path. > > Fixes: eaeb39842508 ("IB/ipoib: Move init code to ndo_init") > Signed-off-by: Valentine Fatiev <valentinef@xxxxxxxxxxxx> > Reviewed-by: Feras Daoud <ferasda@xxxxxxxxxxxx> > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > --- > drivers/infiniband/ulp/ipoib/ipoib_main.c | 34 +++++++++++++---------- > 1 file changed, 20 insertions(+), 14 deletions(-) Applied to for-next, thanks Jason