On Thu, Jul 04, 2019 at 10:40:21AM +0300, Leon Romanovsky wrote: > On Wed, Jul 03, 2019 at 07:12:57PM -0700, Jeff Kirsher wrote: > > From: Mustafa Ismail <mustafa.ismail@xxxxxxxxx> > > > > Add ABI definitions for irdma. > > > > Signed-off-by: Mustafa Ismail <mustafa.ismail@xxxxxxxxx> > > Signed-off-by: Shiraz Saleem <shiraz.saleem@xxxxxxxxx> > > include/uapi/rdma/irdma-abi.h | 130 ++++++++++++++++++++++++++++++++++ > > 1 file changed, 130 insertions(+) > > create mode 100644 include/uapi/rdma/irdma-abi.h > > > > diff --git a/include/uapi/rdma/irdma-abi.h b/include/uapi/rdma/irdma-abi.h > > new file mode 100644 > > index 000000000000..bdfbda4c829e > > +++ b/include/uapi/rdma/irdma-abi.h > > @@ -0,0 +1,130 @@ > > +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */ > > +/* Copyright (c) 2006 - 2019 Intel Corporation. All rights reserved. > > + * Copyright (c) 2005 Topspin Communications. All rights reserved. > > + * Copyright (c) 2005 Cisco Systems. All rights reserved. > > + * Copyright (c) 2005 Open Grid Computing, Inc. All rights reserved. > > + */ > > + > > +#ifndef IRDMA_ABI_H > > +#define IRDMA_ABI_H > > + > > +#include <linux/types.h> > > + > > +/* irdma must support legacy GEN_1 i40iw kernel > > + * and user-space whose last ABI ver is 5 > > + */ > > +#define IRDMA_ABI_VER 6 > > Can you please elaborate about it more? > There is no irdma code in RDMA yet, so it makes me wonder why new define > shouldn't start from 1. It is because they are ABI compatible with the current user space, which raises the question why we even have this confusing header file.. I think this needs to be added after you delete the old driver. Jason
