Re: [PATCH rdma-next v3 2/3] RDMA/core: Provide RDMA DIM support for ULPs

[Sagi Grimberg <sagi@xxxxxxxxxxx>]

Can you please split the mlx5 to its own patch?

> +static void ib_cq_rdma_dim_work(struct work_struct *w)
> +{
> +	struct dim *dim = container_of(w, struct dim, work);
> +	struct ib_cq *cq = (struct ib_cq *)dim->dim_owner;

No need to cast a void pointer

>   static int __ib_process_cq(struct ib_cq *cq, int budget, struct ib_wc *wcs,
>   			   int batch)
>   {
> @@ -78,6 +112,7 @@ static void ib_cq_completion_direct(struct ib_cq *cq, void *private)
>   static int ib_poll_handler(struct irq_poll *iop, int budget)
>   {
>   	struct ib_cq *cq = container_of(iop, struct ib_cq, iop);
> +	struct dim *dim = cq->dim;
>   	int completed;

Is there really a need for this local variable? I'd say you can safely
drop it.

The rest looks fine.