On Mon, Jun 24, 2019 at 09:57:05PM +0000, Saeed Mahameed wrote: > On Wed, 2019-06-19 at 07:45 +0300, Leon Romanovsky wrote: > > On Tue, Jun 18, 2019 at 06:51:45PM +0000, Saeed Mahameed wrote: > > > On Tue, 2019-06-18 at 20:15 +0300, Leon Romanovsky wrote: > > > > From: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > > > > > > > Changelog: > > > > v0 -> v1: > > > > > > Normally 1st submission is V1 and 2nd is V2. > > > so this should have been v1->v2. > > > > "Normally" depends on the language you are using. In C, everything > > starts from 0, including version of patches :). > > > > You are wrong: > quoting: https://kernelnewbies.org/PatchTipsAndTricks > > "For example, if you're sending the second revision of a patch, you > should use [PATCH v2]." > > now don't tell me that second revision is actually 3rd revision or 1st > is 2nd :).. :) If you don't mind, I will stick to common sense (v0, v1, v2 ...) and official kernel documentation, which mentions existence of v1. https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L682 > > > > For mlx5-next patches: > > > > > > Acked-by: Saeed Mahameed <saeedm@xxxxxxxxxxxx> > > > > Thanks