On Thu, Jun 27, 2019 at 09:35:16PM +0000, Michal Kalderon wrote: > > > The flags taken from EFA aren't necessarily going to work for other drivers. > > > Maybe the flags bits should be opaque to ib_core and leave the actual > > > mmap callbacks in the drivers. Not sure how dealloc_ucontext is going > > > to work with opaque flags though? > > > > Yes, the driver will have to take care of masking the flags before lookup > > The efa flags seemed pretty generic, perhaps we should have two sets ? > This way if a driver ( like mlx5) has additional flags it can have it's own > Mmap function and for the generic flags call the common mmap function. The flags are part of the driver ABI, so to convert anything to use this new common code still requires the driver to process its historical flag values somehow... Jason
