RE: [PATCH v2] rsockets: fix variable initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> This is to fix the error:
>   ```
>   [117/380] Building C object librdmacm/CMakeFiles/rdmacm.dir/rsocket.c.o
>   FAILED: librdmacm/CMakeFiles/rdmacm.dir/rsocket.c.o
>   /usr/bin/cc  -D_FILE_OFFSET_BITS=64 -Drdmacm_EXPORTS -Werror -m32
>   -std=gnu11 -Wall -Wextra -Wno-sign-compare -Wno-unused-parameter
>   -Wmissing-prototypes -Wmissing-declarations -Wwrite-strings -Wformat=2
>   -Wformat-nonliteral -Wredundant-decls -Wnested-externs -Wshadow
>   -Wno-missing-field-initializers -Wstrict-prototypes
>   -Wold-style-definition -Wredundant-decls -O2 -g  -fPIC -Iinclude -MMD
>   -MT librdmacm/CMakeFiles/rdmacm.dir/rsocket.c.o -MF
>   "librdmacm/CMakeFiles/rdmacm.dir/rsocket.c.o.d" -o
>   librdmacm/CMakeFiles/rdmacm.dir/rsocket.c.o   -c ../librdmacm/rsocket.c
>   ../librdmacm/rsocket.c: In function ‘rs_get_comp’:
>   ../librdmacm/rsocket.c:2148:15: error: ‘start_time’ may be used
>   uninitialized in this function [-Werror=maybe-uninitialized]
>      poll_time = (uint32_t) (rs_time_us() - start_time);
>                  ^
>   ../librdmacm/rsocket.c: In function ‘ds_get_comp’:
>   ../librdmacm/rsocket.c:2307:15: error: ‘start_time’ may be used
>   uninitialized in this function [-Werror=maybe-uninitialized]
>      poll_time = (uint32_t) (rs_time_us() - start_time);
>                  ^
>   ../librdmacm/rsocket.c: In function ‘rpoll’:
>   ../librdmacm/rsocket.c:3321:15: error: ‘start_time’ may be used
>   uninitialized in this function [-Werror=maybe-uninitialized]
>      poll_time = (uint32_t) (rs_time_us() - start_time);
>                  ^
>   cc1: all warnings being treated as errors
>   [122/380] Building C object providers/efa/CMakeFiles/efa.dir/verbs.c.o
>   ninja: build stopped: subcommand failed.
>   ```
> Which reproduces on RHEL7.5 with 4.8.5 20150623 (Red Hat 4.8.5-28)
> and 32-bit libraries.
> 
> Build steps to reproduce:
>   ```
>   mkdir build32 && cd build32 && CFLAGS="-Werror -m32" cmake -GNinja \
>   -DENABLE_RESOLVE_NEIGH=0 -DIOCTL_MODE=both -DNO_PYVERBS=1 && \
>   ninja-build
>   ```
> 
> meson version: 0.47.2
> ninja-build version: 1.7.2
> 
> Fixes: 38c49232b67a ("rsockets: Replace gettimeofday with clock_gettime")
> Cc: sean.hefty@xxxxxxxxx
> 
> Signed-off-by: Ali Alnubani <alialnu@xxxxxxxxxxxx>

Thanks

Acked-by: Sean Hefty <sean.hefty@xxxxxxxxx>




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux