On Wed, Jun 26, 2019 at 1:03 AM Sagi Grimberg <sagi@xxxxxxxxxxx> wrote:
>
> > +void rdma_dim(struct dim *dim, u64 completions)
> > +{
> > + struct dim_sample *curr_sample = &dim->measuring_sample;
> > + struct dim_stats curr_stats;
> > + u32 nevents;
> > +
> > + dim_update_sample_with_comps(curr_sample->event_ctr + 1,
> > + curr_sample->pkt_ctr,
> > + curr_sample->byte_ctr,
> > + curr_sample->comp_ctr + completions,
> > + &dim->measuring_sample);
>
> If this is the only caller, why add pkt_ctr and byte_ctr at all?
Hi Sagi,
Thanks for the fast review and feedback, other than the default per
ib/rdma device setup for rdma
dim / adaptive-moderation for which Idan commented on (and lets
discuss it there please) seems
the rest of the comments are fine and Yamin will respond / address
them in the coming days.
Or.
