Re: [PATCH rdma-next] RDMa/hns: Don't stuck in endless timeout loop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2019-06-16 at 15:05 +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> 
> The "end" variable is declared as unsigned and can't be negative, it
> leads to the situation where timeout limit is not honored, so let's
> convert logic to ensure that loop is bounded.
> 
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c: In function
> _hns_roce_v1_clear_hem_:
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c:2471:12: warning:
> comparison of unsigned expression < 0 is always false [-Wtype-limits]
>  2471 |    if (end < 0) {
>       |            ^
> 
> Fixes: 669cefb654cb ("RDMA/hns: Remove jiffies operation in disable
> interrupt context")
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>

Thanks, applied to for-next.

-- 
Doug Ledford <dledford@xxxxxxxxxx>
    GPG KeyID: B826A3330E572FDD
    Fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux