On Wed, 2019-06-12 at 15:55 +0300, Yuval Shaia wrote:
> On Wed, Jun 12, 2019 at 03:51:12PM +0300, Leon Romanovsky wrote:
> > On Wed, Jun 12, 2019 at 03:40:50PM +0300, Yuval Shaia wrote:
> > > On Wed, Jun 12, 2019 at 03:27:41PM +0300, Leon Romanovsky wrote:
> > > > From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> > > >
> > > > All callers of destroy WQ are always success and there is no
> > > > need
> > > > to check their return value, so convert destroy_wq to be void.
> > > >
> > > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> > > > ---
> > > > drivers/infiniband/core/verbs.c | 12 +++++-------
> > > > drivers/infiniband/hw/mlx4/mlx4_ib.h | 2 +-
> > > > drivers/infiniband/hw/mlx4/qp.c | 4 +---
> > > > drivers/infiniband/hw/mlx5/mlx5_ib.h | 2 +-
> > > > drivers/infiniband/hw/mlx5/qp.c | 4 +---
> > > > include/rdma/ib_verbs.h | 2 +-
> > > > 6 files changed, 10 insertions(+), 16 deletions(-)
> > > >
> > > > diff --git a/drivers/infiniband/core/verbs.c
> > > > b/drivers/infiniband/core/verbs.c
> > > > index 2fb834bb146c..d55f491be24f 100644
> > > > --- a/drivers/infiniband/core/verbs.c
> > > > +++ b/drivers/infiniband/core/verbs.c
> > > > @@ -2344,19 +2344,17 @@ EXPORT_SYMBOL(ib_create_wq);
> > > > */
> > > > int ib_destroy_wq(struct ib_wq *wq, struct ib_udata *udata)
> > >
> > > So why this one left out of this change?
> >
> > This function can return -EBUSY.
>
> Missed that.
>
> > > > {
> > > > - int err;
> > > > struct ib_cq *cq = wq->cq;
> > > > struct ib_pd *pd = wq->pd;
> > > >
> > > > if (atomic_read(&wq->usecnt))
> > > > return -EBUSY;
> >
> > Thanks
>
> Reviewed-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>
>
Applied to for-next, thanks.
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: B826A3330E572FDD
Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
Attachment:
signature.asc
Description: This is a digitally signed message part
