On Tue, Jun 11, 2019 at 06:52:36PM +0300, Max Gurtovoy wrote: > Hello Sagi, Christoph, Keith, Jason, Doug, Leon and Co > > This patchset adds a new verbs API for T10-PI offload and > implementation for iSER initiator and iSER target (NVMe-oF/RDMA host side > was completed and will be sent on a different patchset). > This set starts with a few preparation commits to the RDMA/core layer. > It continues with introducing a new MR type IB_MR_TYPE_INTEGRITY. > Using this MR all the needed mappings will be done in the low level drivers > and not be visible to the ULP. Later patches implement the needed functionality > in the mlx5 layer. As suggested by Sagi, in the new API, the mlx5 driver > will allocate a single internal memory region for the UMR operation to > register both PI and data SG lists and it will look like: > > data start meta start > | | > |d1|d2|d3|d4|m1|m2|m3|m4| > > The sig_mr stride block would be using the same lkey but different > offsets in it (offset 0 and offset d1+d2+d3+d4). The verbs layer will > use a special mr type that will describe everything and will replace > the old API, that enforce using 3 different memory regions (data_mr, > protection_mr, sig_mr) and their local invalidations. This will ease > the code in the ULP and will improve the abstraction of the HW (see > iSER code changes). > The patchset contains also iSER initator and target patches that using > this new API. > > For iSER, the code was tested vs. LIO iSER target using Mellanox's > ConnectX-4/ConnectX-5. > > This series applies cleanly on top of kernel 5.2.0-rc4 tag plus patchest > "[PATCH 0/7] iser/isert/rw-api cleanups" that was applied to for-next (Jason). > We should aim to push this code during 5.3 merge window. > > Next steps are: > - merge NVMe-oF/RDMA host side after merging this patchset > - Implement metadata support for NVMe-oF/RDMA target side with new API > > Changes since v5: > > - Rebase the code over kernel 5.2.0-rc4 > - Change return value of ib_map_mr_sg_pi() to success/fail > (patches 4, 6, 11 and 16 were changed - Sagi). > - Squash and refactor "Validate signature handover device cap" and > "Move signature_en attribute from mlx5_qp to ib_qp". > (patch 15/21 - Christoph) > - Split out helper function at RW (patches 16/21 and 17/21 - Christoph) > - Rename signature qp create flag and signature device capability > (patch 14/21 - Sagi) > - Added Reviewed-by signatures It looks to me like we are done with this now, yes? I'll apply it tomorrow then. Thanks, Jason
