On Tue, 2019-06-18 at 10:47 +0000, Parav Pandit wrote: > Hi Leon, > > > -----Original Message----- > > From: Leon Romanovsky > > Sent: Tuesday, June 18, 2019 4:12 PM > > To: Saeed Mahameed <saeedm@xxxxxxxxxxxx> > > Cc: netdev@xxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; Bodong Wang > > <bodong@xxxxxxxxxxxx>; Parav Pandit <parav@xxxxxxxxxxxx>; Mark > > Bloch > > <markb@xxxxxxxxxxxx> > > Subject: Re: [PATCH mlx5-next 14/15] {IB, net}/mlx5: E-Switch, Use > > index of rep > > for vport to IB port mapping > > > > On Mon, Jun 17, 2019 at 07:23:37PM +0000, Saeed Mahameed wrote: > > > From: Bodong Wang <bodong@xxxxxxxxxxxx> > > > > > > In the single IB device mode, the mapping between vport number > > > and rep > > > relies on a counter. However for dynamic vport allocation, it is > > > desired to keep consistent map of eswitch vport and IB port. > > > > > > Hence, simplify code to remove the free running counter and > > > instead > > > use the available vport index during load/unload sequence from > > > the > > > eswitch. > > > > > > Signed-off-by: Bodong Wang <bodong@xxxxxxxxxxxx> > > > Suggested-by: Parav Pandit <parav@xxxxxxxxxxxx> > > > Reviewed-by: Parav Pandit <parav@xxxxxxxxxxxx> > > > > We are not adding multiple "*-by" for same user, please choose one. > > > Suggested-by was added by Bodong during our discussion. Later on when > I did gerrit +1, RB tag got added. > Is there a rule against having multiple "*-by" ? i don't think so and there shouldn't be, users need to get the exact amount of recognition as the amount of work they put into this patch, if they reviewed and tested a patch they deserve two tags ..