On Tue, Jun 18, 2019 at 04:47:17PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
>
> Incorrect linkage type causes to linkage errors on PPC platform.
>
> [267/395] Linking C executable bin/mcm_rereg_test
> FAILED: bin/mcm_rereg_test
> : && /usr/bin/cc -std=gnu11 -Wall -Wextra -Wno-sign-compare -Wno-unused-parameter -Wmissing-prototypes -Wmissing-declarations
> -Wwrite-strings -Wformat=2 -Wformat-nonliteral -Wredundant-decls -Wnested-externs -Wshadow -Wno-missing-field-i
> nitializers -Wstrict-prototypes -Wold-style-definition -Wredundant-decls -O2 -g -Wl,--as-needed -Wl,--no-undefined
> infiniband-diags/CMakeFiles/mcm_rereg_test.dir/mcm_rereg_test.c.o -o bin/mcm_rereg_test ccan/libccan.a util/librdma_util
> .a -lPRIVATE lib/libibumad.so.3.0.25.0 lib/libibmad.so.5.3.25.0 infiniband-diags/libibdiags_tools.a lib/libibumad.so.3.0.25.0
> -Wl,-rpath,/tmp/rdma-core/build/lib &&
> : /usr/bin/ld: cannot find -lPRIVATE
> collect2: error: ld returned 1 exit status
Weird that only happens on PPC, IIRC'PRIVATE' is a valid cmake keyword but
it is archaic.
> Fixes: 58670e0a17ba ("ibdiags: Add cmake files for ibdiags components")
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> infiniband-diags/CMakeLists.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
Jason
