re: RDMA: Clean destroy CQ in drivers do not return errors

Colin Ian King <colin.king@xxxxxxxxxxxxx> · Fri, 14 Jun 2019 14:59:32 +0100

Hi,

Static analysis with Coverity reported an issue with the following commit:

commit a52c8e2469c30cf7ac453d624aed9c168b23d1af
Author: Leon Romanovsky <leonro@xxxxxxxxxxxx>
Date:   Tue May 28 14:37:28 2019 +0300

    RDMA: Clean destroy CQ in drivers do not return errors

In function bnxt_re_destroy_cq() contains the following:

        if (!cq->umem)
                ib_umem_release(cq->umem);

Coverity detects this as a deference after null check on the null
pointer cq->umem:

"var_deref_model: Passing null pointer cq->umem to ib_umem_release,
which dereferences it"

Is the logic inverted on that null check?

Colin