在 2019/6/13 1:23, Leon Romanovsky 写道: > On Sat, Jun 08, 2019 at 12:27:14PM +0300, Dan Carpenter wrote: >> This function is supposed to return negative kernel error codes but here >> it returns CMD_RST_PRC_EBUSY (2). The error code eventually gets passed >> to IS_ERR() and since it's not an error pointer it leads to an Oops in >> hns_roce_v1_rsv_lp_qp() >> >> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> >> --- >> Static analysis. Not tested. >> >> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c >> index ac017c24b200..018ff302ab9e 100644 >> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c >> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c >> @@ -1098,7 +1098,7 @@ static int hns_roce_cmq_send(struct hns_roce_dev *hr_dev, >> if (ret == CMD_RST_PRC_SUCCESS) >> return 0; >> if (ret == CMD_RST_PRC_EBUSY) > The better fix will be to remove CMD_RST_PRC_* definitions in favor of > normal errno. > > Thanks > > . > Sorry, Our guys are analyzing his influence. So the response is a bit late.
