On 6/12/19, Michal Kubecek <mkubecek@xxxxxxx> wrote: > On Wed, Jun 12, 2019 at 01:33:48PM +0200, Denis Kirjanov wrote: >> in IPoIB case we can't see a VF broadcast address for but >> can see for PF >> >> Before: >> 11: ib1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 2044 qdisc pfifo_fast >> state UP mode DEFAULT group default qlen 256 >> link/infiniband >> 80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd >> 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff >> vf 0 MAC 14:80:00:00:66:fe, spoof checking off, link-state disable, >> trust off, query_rss off >> ... >> >> After: >> 11: ib1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 2044 qdisc pfifo_fast >> state UP mode DEFAULT group default qlen 256 >> link/infiniband >> 80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd >> 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff >> vf 0 link/infiniband >> 80:00:00:66:fe:80:00:00:00:00:00:00:24:8a:07:03:00:a4:3e:7c brd >> 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff, spoof >> checking off, link-state disable, trust off, query_rss off >> ... >> >> Signed-off-by: Denis Kirjanov <dkirjanov@xxxxxxxx> >> --- >> net/core/rtnetlink.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c >> index 2e1b9ffbe602..f70902b57a40 100644 >> --- a/net/core/rtnetlink.c >> +++ b/net/core/rtnetlink.c >> @@ -1248,6 +1248,7 @@ static noinline_for_stack int >> rtnl_fill_vfinfo(struct sk_buff *skb, >> if (!vf) >> goto nla_put_vfinfo_failure; >> if (nla_put(skb, IFLA_VF_MAC, sizeof(vf_mac), &vf_mac) || >> + nla_put(skb, IFLA_BROADCAST, dev->addr_len, dev->broadcast) || >> nla_put(skb, IFLA_VF_VLAN, sizeof(vf_vlan), &vf_vlan) || >> nla_put(skb, IFLA_VF_RATE, sizeof(vf_rate), >> &vf_rate) || > > This doesn't seem right, IFLA_BROADCAST is 2 which is the same as > IFLA_VF_VLAN. You should add a new constant in the same enum as other > IFLA_VF_* attribute types expected in this context. You should then also > add an entry to ifla_vf_policy and account for the new attribute size in > rtnl_vfinfo_size(). Ah, ok, Thanks > > Michal >
