-----"Leon Romanovsky" <leon@xxxxxxxxxx> wrote: ----- >To: "Bernard Metzler" <bmt@xxxxxxxxxxxxxx> >From: "Leon Romanovsky" <leon@xxxxxxxxxx> >Date: 06/10/2019 09:35AM >Cc: linux-rdma@xxxxxxxxxxxxxxx >Subject: [EXTERNAL] Re: [PATCH for-next v1 11/12] SIW debugging > >On Sun, May 26, 2019 at 01:41:55PM +0200, Bernard Metzler wrote: >> Signed-off-by: Bernard Metzler <bmt@xxxxxxxxxxxxxx> >> --- >> drivers/infiniband/sw/siw/siw_debug.c | 102 >++++++++++++++++++++++++++ >> drivers/infiniband/sw/siw/siw_debug.h | 35 +++++++++ >> 2 files changed, 137 insertions(+) >> create mode 100644 drivers/infiniband/sw/siw/siw_debug.c >> create mode 100644 drivers/infiniband/sw/siw/siw_debug.h > >1. Use Gal's ibdev_* prints. I'll have a look now. >2. Remove all your custom siw_print_hdr() thing. It belongs to custom >debug kernel which you can use in-house, but not for upstream and >globally distributed code. Our assumption that code works. OK will remove. Have to say siw initially targeted RDMA application debugging, that's why it had that many debug statements. slowly cleaning up ;) > >Thanks > >
