On Fri, Jun 07, 2019 at 03:39:06PM -0700, Ralph Campbell wrote: > > > + range->hmm = hmm; > > > + kref_get(&hmm->kref); > > > /* Initialize range to track CPU page table updates. */ > > > mutex_lock(&hmm->lock); > > > > > I forgot to add that I think you can delete the duplicate > "range->hmm = hmm;" > here between the mutex_lock/unlock. Done, thanks Jason