Re: [PATCH 16/20] RDMA/rw: Use IB_WR_REG_MR_INTEGRITY for PI handover

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 16/20] RDMA/rw: Use IB_WR_REG_MR_INTEGRITY for PI handover
From: Sagi Grimberg <sagi@xxxxxxxxxxx>
Date: Wed, 5 Jun 2019 15:55:14 -0700
Cc: leonro@xxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, jgg@xxxxxxxxxxxx, dledford@xxxxxxxxxx, bvanassche@xxxxxxx, israelr@xxxxxxxxxxxx, idanb@xxxxxxxxxxxx, oren@xxxxxxxxxxxx, vladimirk@xxxxxxxxxxxx, shlomin@xxxxxxxxxxxx
In-reply-to: <20190604075336.GS15680@lst.de>
References: <1559222731-16715-1-git-send-email-maxg@mellanox.com> <1559222731-16715-17-git-send-email-maxg@mellanox.com> <20190604075336.GS15680@lst.de>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

+	memcpy(ctx->reg->mr->sig_attrs, sig_attrs, sizeof(struct ib_sig_attrs));


Why do we need to do a struct copy here instead of setting up a pointer?


Yea, can't we use the mr->sig_attrs directly?

Follow-Ups:
- Re: [PATCH 16/20] RDMA/rw: Use IB_WR_REG_MR_INTEGRITY for PI handover
  - From: Max Gurtovoy

References:
- [PATCH 00/20 V5] Introduce new API for T10-PI offload
  - From: Max Gurtovoy
- [PATCH 16/20] RDMA/rw: Use IB_WR_REG_MR_INTEGRITY for PI handover
  - From: Max Gurtovoy
- Re: [PATCH 16/20] RDMA/rw: Use IB_WR_REG_MR_INTEGRITY for PI handover
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 18/20] RDMA/mlx5: Improve PI handover performance
Next by Date: Re: [PATCH 19/20] RDMA/mlx5: Use PA mapping for PI handover
Previous by thread: Re: [PATCH 16/20] RDMA/rw: Use IB_WR_REG_MR_INTEGRITY for PI handover
Next by thread: Re: [PATCH 16/20] RDMA/rw: Use IB_WR_REG_MR_INTEGRITY for PI handover
Index(es):
- Date
- Thread

[Index of Archives] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Photo] [Yosemite News] [Yosemite Photos] [Linux Kernel] [Linux SCSI] [XFree86]

Powered by Linux