On Wed, May 22, 2019 at 12:22:42AM +0000, Jason Gunthorpe wrote: > On Mon, May 20, 2019 at 10:53:21AM +0300, Shamir Rabinovitch wrote: > > future patches will add the ability to share ib_pd across multiple > > ib_ucontext. given that, ib_pd will be pointed by 1 or more ib_uobject. > > thus, having ib_uobject pointer in ib_pd is incorrect. > > > > Signed-off-by: Shamir Rabinovitch <shamir.rabinovitch@xxxxxxxxxx> > > --- > > drivers/infiniband/core/uverbs_cmd.c | 1 - > > drivers/infiniband/core/verbs.c | 1 - > > drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 1 - > > drivers/infiniband/hw/mlx5/main.c | 1 - > > drivers/infiniband/hw/mthca/mthca_qp.c | 3 ++- > > include/rdma/ib_verbs.h | 1 - > > 6 files changed, 2 insertions(+), 6 deletions(-) > > Please remove the uobject from the mr as well, those are the two > objects I want to see be sharable to start. > > Jason Jason would it be OK to progress with PD first and later come back to MR? Can we finish to review/merge the PD clean up ? Thanks