On Mon, May 06, 2019 at 05:52:48PM +0000, Marciniszyn, Mike wrote: > > > > My mistake. It's been a long while since I coded the stuff I did for > > memory reclaim pressure and I had my flag usage wrong in my memory. > > From the description you just gave, the original patch to add > > WQ_MEM_RECLAIM is ok. I probably still need to audit the ipoib usage > > though. > > > > -- > > Doug Ledford <dledford@xxxxxxxxxx> > > GPG KeyID: B826A3330E572FDD > > Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD > > Don't lose sight of the fact that the additional of the WQ_MEM_RECLAIM is to silence > a warning BECAUSE ipoib's workqueue is WQ_MEM_RECLAIM. This happens while > rdmavt/hfi1 is doing a cancel_work_sync() for the work item used by the QP's send engine > > The ipoib wq needs to be audited to see if it is in the data path for VM I/O. It is, at least we had a test of NFS running over IPoIB and it needed WQ_MEM_RECLAIM back then. Thanks > > Mike > >
