On Mar 27, 2019, at 1:02 PM, Leon Romanovsky <leon@xxxxxxxxxx> wrote:
>
> On Wed, Mar 27, 2019 at 08:25:17AM -0700, Tejun Heo (tj@xxxxxxxxxx) wrote:
>> Hello,
>>
>> On Tue, Mar 26, 2019 at 08:55:09PM +0000, Marciniszyn, Mike wrote:
>>> The latter is the ipoib wq that conflicts with our non-WQ_MEM_RECLAIM. This seems excessive and pretty gratuitous.
>>>
>>> Tejun, what does "mem reclaim" really mean and when should it be used?
>>
>> That it may be depended during memory reclaim.
>>
>>> I was assuming that since we are freeing QP kernel memory held by user mode programs that could be oom killed, we need the flag.
>>
>> If it can't block memory reclaim, it doesn't need the flag. Just in
>> case, if a workqueue is used to issue block IOs, it is depended upon
>> for memory reclaim as writeback and swap-outs are critical parts of
>> memory reclaim.
>
> It looks like WQ_MEM_RECLAIM is needed for IPoIB, because if NFS runs
> over IPoIB, it will do those types of IOs.
Because of what IPoIB does, you’re right that it’s needed. However, it might be necessary to audit the wq usage in IPoIB to make sure it’s actually eligible for the flag and that it hasn’t been set when the code doesn’t meet the requirements of the flag.
> Thanks
>
>>
>> Thanks.
>>
>> --
>> tejun
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
Attachment:
signature.asc
Description: Message signed with OpenPGP
