On Wed, 24 Apr 2019 17:08:20 +0300, Dan Carpenter wrote: > To me making "vf" a u32 throughout seems like a good idea but it's an > extensive patch and I'm not really able to test it at all. But maybe > there is a better place to check for negatives. Or maybe we are already > checking for negatives and I haven't seen it. (I don't know this code > very well at all). Could we please add the checks in the core? We already have the infra in place for calculating dump sizes - i.e. int num_vfs = dev_num_vf(dev->dev.parent); We just need to validate the set params. Callback parameters should really be validated by the core to the extent possible, unfortunately driver authors have little incentive to improve that once an API is implemented, realistically we all need to support old kernels wouldn't do the checking..
