-----"Olga Kornievskaia" <aglo@xxxxxxxxx> wrote: ----- >To: "Jason Gunthorpe" <jgg@xxxxxxxx> >From: "Olga Kornievskaia" <aglo@xxxxxxxxx> >Date: 04/24/2019 06:17PM >Cc: "Bernard Metzler" <bmt@xxxxxxxxxxxxxx>, "linux-rdma" ><linux-rdma@xxxxxxxxxxxxxxx> >Subject: Re: [PATCH v7 00/12] SIW: Request for Comments > >On Mon, Apr 22, 2019 at 12:48 PM Jason Gunthorpe <jgg@xxxxxxxx> >wrote: >> >> On Wed, Apr 17, 2019 at 05:00:39PM +0200, Bernard Metzler wrote: >> > This patch set contributes version 7 of the SoftiWarp >> > driver, as originally introduced to the list Oct 6th, 2017. >> > SoftiWarp (siw) implements the iWarp RDMA protocol over >> > kernel TCP sockets. The driver integrates with the >> > linux-rdma framework. >> > >> > Mainly in response to the various helpful feedback, >> > I fixed the following issues: >> > >> > 1. The code now relies on proper object management >> > provided by the RDMA midlayer. With that, reference >> > counting for PD's, CQ's and SRQ's got dropped. >> > The corresponding files siw_obj.[ch] are removed. >> > >> > 2. The code now supports multiple user mmap operations >> > of the same object (CQ, SQ, RQ, SRQ array) during >> > its lifetime. To efficiently maintain the potentially >> > large number of objects, those are now kept in a >> > user context private cyclic xarray. >> > >> > 3. siw private memory access flags definition got dropped >> > in favor of ib_access_flags. >> > >> > 4. Added code to consistently check complete STag >> > during memory access - checking the user controlled >> > 8 bit 'key' field was inconsistent and partially >> > missing. >> > >> > We maintain a snapshot of the current code at >> > >https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_zrlio >_softiwarp-2Dfor-2Dlinux-2Drdma.git&d=DwIBaQ&c=jf_iaSHvJObTbx-siA1ZOg >&r=2TaYXQ0T-r8ZO1PP1alNwU_QJcRRLfmYTAgd3QCvqSc&m=G3P_ssjY7cDr3ZnlNjL7 >9Rb33OU_zvaWf0Reg-1NgQY&s=wC0ep1X5bQaX9RfmXhTHqtJjjQAttfWGS17XvMaWx3k >&e= >> > within branch 'siw-for-rdma-next-v7'. >> > >> > The matching siw user library is maintained at >> > >https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_zrlio >_softiwarp-2Duser-2Dfor-2Dlinux-2Drdma.git&d=DwIBaQ&c=jf_iaSHvJObTbx- >siA1ZOg&r=2TaYXQ0T-r8ZO1PP1alNwU_QJcRRLfmYTAgd3QCvqSc&m=G3P_ssjY7cDr3 >ZnlNjL79Rb33OU_zvaWf0Reg-1NgQY&s=pZ3roHqww6w4Py43ZpROWVrRu48GepKSlpzX >WFSoQoc&e=. >> > The relevant branch name is 'siw-for-rdma-next-v7'. >> > >> > As always, I highly appreciate your feedback. Thanks >> > very much for your time and help! >> >> As before, I really want to see the various people stand up and say >> this driver works, it passes their existing test suites (NFS, SRP, >> iSER, NVMEOf, etc, etc) >> >> I think that is the main remaning blocker to acceptance. > >Hi Jason, > >I'd like to provide my feedback about testing this code and running >NFS over RDMA over the software iWarp. With much appreciated help >from >Bernard, I setup 2 CentOS 7.6 VMs and his v7 kernel branch. I >successfully, ran NFS connectathon test suite, xfstests, and ran >"make >-j" compile of the linux kernel. Current code is useful for NFSoRDMA >functional testing. From a very limited comparison timing study in >all >virtual environment, it is lacking a bit in performance compared to >non-RDMA mount (but it's better than software RoCE). > Hi Olga, Many thanks again for taking the time to check siw! It's only your testing which pointed me to an issue in the last patch series. siw did not take into account a new io-address as potentially provided by the user during fast register. Thanks and best regards, Bernard.
