On Wed, Apr 24, 2019 at 12:17:15PM -0400, Olga Kornievskaia wrote: > On Mon, Apr 22, 2019 at 12:48 PM Jason Gunthorpe <jgg@xxxxxxxx> wrote: > > > > On Wed, Apr 17, 2019 at 05:00:39PM +0200, Bernard Metzler wrote: > > > This patch set contributes version 7 of the SoftiWarp > > > driver, as originally introduced to the list Oct 6th, 2017. > > > SoftiWarp (siw) implements the iWarp RDMA protocol over > > > kernel TCP sockets. The driver integrates with the > > > linux-rdma framework. > > > > > > Mainly in response to the various helpful feedback, > > > I fixed the following issues: > > > > > > 1. The code now relies on proper object management > > > provided by the RDMA midlayer. With that, reference > > > counting for PD's, CQ's and SRQ's got dropped. > > > The corresponding files siw_obj.[ch] are removed. > > > > > > 2. The code now supports multiple user mmap operations > > > of the same object (CQ, SQ, RQ, SRQ array) during > > > its lifetime. To efficiently maintain the potentially > > > large number of objects, those are now kept in a > > > user context private cyclic xarray. > > > > > > 3. siw private memory access flags definition got dropped > > > in favor of ib_access_flags. > > > > > > 4. Added code to consistently check complete STag > > > during memory access - checking the user controlled > > > 8 bit 'key' field was inconsistent and partially > > > missing. > > > > > > We maintain a snapshot of the current code at > > > https://github.com/zrlio/softiwarp-for-linux-rdma.git > > > within branch 'siw-for-rdma-next-v7'. > > > > > > The matching siw user library is maintained at > > > https://github.com/zrlio/softiwarp-user-for-linux-rdma.git. > > > The relevant branch name is 'siw-for-rdma-next-v7'. > > > > > > As always, I highly appreciate your feedback. Thanks > > > very much for your time and help! > > > > As before, I really want to see the various people stand up and say > > this driver works, it passes their existing test suites (NFS, SRP, > > iSER, NVMEOf, etc, etc) > > > > I think that is the main remaning blocker to acceptance. > > Hi Jason, > > I'd like to provide my feedback about testing this code and running > NFS over RDMA over the software iWarp. With much appreciated help from > Bernard, I setup 2 CentOS 7.6 VMs and his v7 kernel branch. I > successfully, ran NFS connectathon test suite, xfstests, and ran "make > -j" compile of the linux kernel. Current code is useful for NFSoRDMA > functional testing. From a very limited comparison timing study in all > virtual environment, it is lacking a bit in performance compared to > non-RDMA mount (but it's better than software RoCE). Excellent feed back, thank you. Lets hear from NVMeof too please Jason
