Re: [PATCH rdma-next] RDMA/hns: Remove asynchronic QP destroy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 23, 2019 at 09:51:23PM +0800, oulijun wrote:
>    在 2019/4/16 20:17, Leon Romanovsky 写道:
> 
> On Thu, Apr 04, 2019 at 09:56:38AM +0300, Leon Romanovsky wrote:
> 
> From: Leon Romanovsky [1]<leonro@xxxxxxxxxxxx>
> 
> Verbs destroy callbacks are synchronous operations and can't be delayed.
> The expectation is that after driver returned from destroy function, the
> memory can be freed and user won't be able to access it again.
> 
> Ditch workqueue implementation used in HNS driver.
> 
> Fixes: d838c481e025 ("IB/hns: Fix the bug when destroy qp")
> Signed-off-by: Leon Romanovsky [2]<leonro@xxxxxxxxxxxx>
>  I don't have HNS hardware, so it is tested with compilation only.
>  drivers/infiniband/hw/hns/hns_roce_common.h |  33 --
>  drivers/infiniband/hw/hns/hns_roce_hw_v1.c  | 374 +-------------------
>  drivers/infiniband/hw/hns/hns_roce_hw_v1.h  |  12 -
>  3 files changed, 13 insertions(+), 406 deletions(-)
> 
> 
> I'm assuming that this patch is working and correct.
> 
> Thanks
> 
>    Ok, thank your fix.

Please don't send HTML mails - they don't get to the list or to
patchworks.

I'm taking this as an ack and have applied the patch to for-next.

Thanks,
Jason




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux