Re: [PATCH rdma-next 4/8] IB/mlx5: Add steering SW ICM device memory type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 24, 2019 at 04:12:22PM +0300, Leon Romanovsky wrote:
> On Wed, Apr 24, 2019 at 10:04:40AM -0300, Jason Gunthorpe wrote:
> > On Sun, Mar 31, 2019 at 07:44:46PM +0300, Leon Romanovsky wrote:
> > > From: Ariel Levkovich <lariel@xxxxxxxxxxxx>
> > >
> > > This patch adds support for allocating, deallocating and registering
> > > a new device memory type, STEERING_SW_ICM.
> > > This memory can be allocated and used by a privileged user for direct
> > > rule insertion and management of the device's steering tables.
> > >
> > > The type is provided by the user via the dedicated attribute in
> > > the alloc_dm ioctl command.
> > >
> > > Signed-off-by: Ariel Levkovich <lariel@xxxxxxxxxxxx>
> > > Reviewed-by: Eli Cohen <eli@xxxxxxxxxxxx>
> > > Reviewed-by: Mark Bloch <markb@xxxxxxxxxxxx>
> > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> > >  drivers/infiniband/hw/mlx5/Kconfig        |   2 +-
> > >  drivers/infiniband/hw/mlx5/cmd.c          | 127 +++++++++++++++++++-
> > >  drivers/infiniband/hw/mlx5/cmd.h          |   6 +-
> > >  drivers/infiniband/hw/mlx5/main.c         | 136 +++++++++++++++++++++-
> > >  drivers/infiniband/hw/mlx5/mlx5_ib.h      |  17 +++
> > >  drivers/infiniband/hw/mlx5/mr.c           |   7 ++
> > >  include/uapi/rdma/mlx5_user_ioctl_verbs.h |   2 +
> > >  7 files changed, 291 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/infiniband/hw/mlx5/Kconfig b/drivers/infiniband/hw/mlx5/Kconfig
> > > index 8d651c05de62..347d457fcb2f 100644
> > > +++ b/drivers/infiniband/hw/mlx5/Kconfig
> > > @@ -1,6 +1,6 @@
> > >  config MLX5_INFINIBAND
> > >  	tristate "Mellanox 5th generation network adapters (ConnectX series) support"
> > > -	depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE
> > > +	depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE && PHYS_ADDR_T_64BIT
> >
> > Why do we need this?
> 
> We are using phys_addr_t type and not u64 as an input to FW to emphasize
> the caller interface, but it is different between 32 and 64 bits systems.
> Such PHYS_ADDR_T_64BIT will ensure that phys_addr_t will be always 64 bits.

???

PHYS_ADDR_T should only ever be used to store a bus address - and if
you are passing a bus address to/from FW then you 0 extend it on 32
bit, and range check on 64 bit.

This is not a reason to force PHYS_ADDR_T_64BIT from a driver

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux