Re: [PATCH V2 for-next] RDMA/hns: Add support function clear when removing module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 23, 2019 at 10:06:31PM +0800, Lijun Ou wrote:
> If carried out unloading operation when application is running, the
> hardware is too late to release some hardware resource that remain
> in it. Under these circumstances, it maybe happen error if loaded hns
> driver and run app again. In order to resolve it, the hardware adds
> a function to stop this function and clear the residual hardware
> resources in the function.
>
> Signed-off-by: chenglang <chenglang@xxxxxxxxxx>
> Signed-off-by: Lijun Ou <oulijun@xxxxxxxxxx>
> ---
> V1->V2:
> 1. rewrite the commit.
> ---
>  drivers/infiniband/hw/hns/hns_roce_device.h |   1 +
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c  | 164 ++++++++++++++++++++++++++++
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.h  |  27 ++++-
>  3 files changed, 191 insertions(+), 1 deletion(-)
>

The same comment, as for v1, you should find the reason where resources
were leaked and fix it, instead of adding reset function with timeouts
and msleep.

Thanks



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux