On Mon, Apr 22, 2019 at 08:53:55PM +0300, Gal Pressman wrote: > On 22-Apr-19 19:32, Jason Gunthorpe wrote: > > On Mon, Apr 15, 2019 at 03:20:30PM +0300, Gal Pressman wrote: > >> Similarly to dev/netdev/etc printk helpers, add standard printk helpers > >> for the RDMA subsystem. > >> > >> Example output: > >> efa 0000:00:06.0 efa_0: Hello World! > >> efa_0: Hello World! (no parent device set) > >> (NULL ib_device): Hello World! (ibdev is NULL) > >> > >> Cc: Jason Baron <jbaron@xxxxxxxxxx> > >> Suggested-by: Jason Gunthorpe <jgg@xxxxxxxx> > >> Suggested-by: Leon Romanovsky <leon@xxxxxxxxxx> > >> Signed-off-by: Gal Pressman <galpress@xxxxxxxxxx> > >> Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > >> drivers/infiniband/core/device.c | 60 ++++++++++++++++++++++++++++++++++++++++ > >> include/linux/dynamic_debug.h | 11 ++++++++ > >> include/rdma/ib_verbs.h | 30 ++++++++++++++++++++ > >> lib/dynamic_debug.c | 40 +++++++++++++++++++++++++++ > >> 4 files changed, 141 insertions(+) > > > > I can remove the two BUG_ONs if we get an ack from the dyanmic_debug > > maintainer.. > > > > Jason Baron? > > I thought we agreed to remove the BUG_ONs unless he objects? Regardless of the BUG_ONs, it still should have an ack from the maintainer who's file we are changing if it goes through the rdma tree Jason
