[PATCH rdma-core] cmake: Explicitly convert build type to be STRING

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Leon Romanovsky <leonro@xxxxxxxxxxxx>

The build type was declared As "String" instead of "STRING" and it
produced the following warning while rdma-core was built.

CMake Warning (dev) at buildlib/RDMA_BuildType.cmake:11 (set):
  implicitly converting 'String' to 'STRING' type.
Call Stack (most recent call first):
  CMakeLists.txt:170 (RDMA_BuildType)
This warning is for project developers.  Use -Wno-dev to suppress it.

Fixes: 7cb1daa8d9e6 ("Be consistent about defining NDEBUG")
Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
---
PR: https://github.com/linux-rdma/rdma-core/pull/516
---
 buildlib/RDMA_BuildType.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/buildlib/RDMA_BuildType.cmake b/buildlib/RDMA_BuildType.cmake
index 0951edad..17206f51 100644
--- a/buildlib/RDMA_BuildType.cmake
+++ b/buildlib/RDMA_BuildType.cmake
@@ -8,7 +8,7 @@ function(RDMA_BuildType)
   # in performance contexts it doesn't make much sense to have the default build
   # turn off the optimizer.
   if(NOT CMAKE_BUILD_TYPE)
-    set(CMAKE_BUILD_TYPE RelWithDebInfo CACHE String
+	  set(CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING
       "Options are ${build_types}"
       FORCE
       )
--
2.20.1




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux