Re: [PATCH rdma-next v5 01/12] RDMA/core: Introduce RDMA subsystem ibdev_* print functions

[Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>]

On 4/15/2019 8:20 AM, Gal Pressman wrote:
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> index 7bdf98c37e91..dfcf6cfa1c70 100644
> --- a/lib/dynamic_debug.c
> +++ b/lib/dynamic_debug.c
> @@ -37,6 +37,8 @@
>   #include <linux/device.h>
>   #include <linux/netdevice.h>
>   
> +#include <rdma/ib_verbs.h>
> +
>   extern struct _ddebug __start___verbose[];
>   extern struct _ddebug __stop___verbose[];
>   
> @@ -636,6 +638,44 @@ EXPORT_SYMBOL(__dynamic_netdev_dbg);
>   
>   #endif
>   
> +#if IS_ENABLED(CONFIG_INFINIBAND)
> +
> +void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
> +			 const struct ib_device *ibdev, const char *fmt, ...)
> +{
> +	struct va_format vaf;
> +	va_list args;
> +
> +	BUG_ON(!descriptor);
> +	BUG_ON(!fmt);

I don't think BUG_ON is going to be acceptable.

-Denny