From: Leon Romanovsky <leonro@xxxxxxxxxxxx> >From Jason, Upon review it turns out there are some long standing problems in BAR mapping area: * BAR pages are being allowed to be executable. * BAR pages intended for read-only can be switched to writable via mprotect. * Missing use of rdma_user_mmap_io for the mlx5 clock BAR page. * Disassociate causes SIGBUS when touching the pages. * CPU pages are being mapped through to the process via remap_pfn_range instead of the more appropriate vm_insert_page, causing weird behaviors during disassociation. This series adds the missing VM_* flag manipulation, adds faulting a zero page for disassociation and revises the CPU page mappings to use vm_insert_page. Thanks Jason Gunthorpe (6): RDMA/mlx5: Do not allow the user to write to the clock page RDMA/mlx5: Use rdma_user_map_io for mapping BAR pages RDMA/ucontext: Do not allow BAR mappings to be executable RDMA/ucontext: Fix regression with disassociate RDMA/mlx5: Use get_zeroed_page() for clock_info RDMA: Remove rdma_user_mmap_page drivers/infiniband/core/uverbs.h | 1 + drivers/infiniband/core/uverbs_main.c | 115 ++++++++++-------- drivers/infiniband/hw/mlx5/main.c | 21 ++-- .../ethernet/mellanox/mlx5/core/lib/clock.c | 30 ++--- include/linux/mlx5/driver.h | 1 - include/rdma/ib_verbs.h | 9 -- 6 files changed, 85 insertions(+), 92 deletions(-) -- 2.20.1
