On Wed, Apr 10, 2019 at 05:10:07AM -0400, Devesh Sharma wrote: > removing the use of IDR variable just to name the > function ids. Using the PCI_FUNC(pdev->devfn) instead > to create the device name, associated resources and > to print driver into at various places. > > Reported-by: Matthew Wilcox <willy@xxxxxxxxxxxxx> > Signed-off-by: Devesh Sharma <devesh.sharma@xxxxxxxxxxxx> > --- > drivers/infiniband/hw/ocrdma/ocrdma_main.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) I'm going to apply this so we can progress on the IDR conversion, but please send a patch fixing this driver to not call pr_err/warn/etc Drivers should be calling dev_warn/etc and not trying to print their own device name. As is this driver has broken logging in the presense of device rename. However, it is worth waiting until Gal's patch is merged to add ib specific printing functions is merged and use those functions instead. https://patchwork.kernel.org/patch/10874849/ Hopefully Gal will resend his patch soon, we can apply it.. Jason
