-----Original Message----- From: Jason Gunthorpe [mailto:jgg@xxxxxxxx] Sent: Thursday, April 11, 2019 2:30 PM To: Arumugam, Kamenee <kamenee.arumugam@xxxxxxxxx> Cc: Dalessandro, Dennis <dennis.dalessandro@xxxxxxxxx>; bhelgaas@xxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; Ruhl, Michael J <michael.j.ruhl@xxxxxxxxx>; dledford@xxxxxxxxxx Subject: Re: [PATCH for-next 2/2] IB/hfi1: Make Unsupported Request error non-fatal On Thu, Apr 11, 2019 at 06:22:45PM +0000, Arumugam, Kamenee wrote: > This is a device bug then. > A RDMA device must accept and respond to all TLPs that the CPU could create for the user accessible BAR pages. > A user process must not be able to crash the CPU or make the device malfunction by accessing the exposed BAR page. This includes a broad range of topics, like mis-aligned acceses, SSE instructions, atomics, >etc. > Is blocking AER even enough here? If the device isn't generating a reasonable reply I have a bad feeling worse will happen. After blocking unsupported request error, we don't see any other issue including no system hang.