Re: [PATCH for-next] RDMA/hns: Support querying qp&mr&pd with rdmatool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 09, 2019 at 07:47:31PM +0800, Lijun Ou wrote:
> Rdmatool supports query qp/mr/pd/cm_id context info.
> Like these:
> ./rdma res show pd
> dev hns_0 local_dma_lkey 0x3793f080 users 2 unsafe_global_rkey 0x0 pid 3713
> comm ib_send_bw drv_pdn 2
> ...
>
> ./rdma res show qp
> link hns_0 lqpn 9 irqpn 8 type RC state RTS rq-psn 12596614 sq-psn 13512359
> path-mig-state ARMED pid 3713 comm ib_send_bw
> mac_idx 0 drv_vid 4095 drv_mtu 3 drv_sgid_idx 2 drv_srqn 0 drv_srq_en 0
> drv_chk_flg 0 drv_retry_cnt 7 drv_err_type 0 drv_flush_idx 0 drv_rq_pi 44192
> drv_rq_ci 38 drv_rq_shift 9 drv_rq_cqeidx 38 drv_rq_rx_err 0 drv_rq_tx_err 0
> drv_rq_rty_tx_err 0 drv_rq_db_doing 0 drv_rx_cqn 4 drv_sq_pi 0 drv_sq_ci 0
> drv_sq_shift 7 drv_sq_maxidx 0 drv_sq_rx_err 0 drv_sq_tx_err 0
> drv_sq_db_doing 0 drv_sq_tx_err 0 drv_tx_cqn 2
> ...
>
> ./rdma res show mr
> dev hns_0 rkey 0x300 lkey 0x300 mrlen 392 pid 3713 comm ib_send_bw
> drv_status 0 drv_lkey 0 drv_size 0 drv_ra 0 drv_ri 0 drv_li 0 drv_atomic_en 0
> drv_rr_en 0 drv_rw_en 0 drv_lw_en 0 drv_pbl_buf_pgsz 0 drv_len 0
>
> Signed-off-by: chenglang <chenglang@xxxxxxxxxx>
> Signed-off-by: Lijun Ou <oulijun@xxxxxxxxxx>
> Reviewed-by: Yixian Liu <liuyixian@xxxxxxxxxx>
> ---
> ---
>  drivers/infiniband/hw/hns/hns_roce_device.h    |   4 +
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c     |   2 +
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.h     |   5 +
>  drivers/infiniband/hw/hns/hns_roce_hw_v2_dfx.c |  56 ++++
>  drivers/infiniband/hw/hns/hns_roce_restrack.c  | 393 +++++++++++++++++++++++++
>  5 files changed, 460 insertions(+)
>

Security and usability are not the shiniest parts of HNS driver.

Without ever looking into details, I see huge number of useless trash
exposed here. Please do your homework, leave only necessary fields which
can change frequently and don't export any PDN, QPN e.t.c., they will be
exported globally to everyone.

Thanks

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux