[PATCH ibdiags 08/16] ibdiags: Remove always true test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Jason Gunthorpe <jgg@xxxxxxxxxxxx>

clang 7.0 says:

../ibdiags/src/iblinkinfo.c:287:19: warning: address of array 'node->info' will always evaluate to 'true' [-Wpointer-bool-conversion]
                        else if (node->info)

So drop the test.

Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
---
 src/iblinkinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/iblinkinfo.c b/src/iblinkinfo.c
index c838afebdaef3b..b7c67e6a5d83ad 100644
--- a/src/iblinkinfo.c
+++ b/src/iblinkinfo.c
@@ -288,7 +288,7 @@ static void print_node_header(ibnd_node_t *node, int *out_header_flag,
 		if (node->type == IB_NODE_SWITCH) {
 			if (node->ports[0])
 				guid = node->ports[0]->guid;
-			else if (node->info)
+			else
 				guid = mad_get_field64(node->info, 0, IB_NODE_PORT_GUID_F);
 
 			printf("%s%s: 0x%016" PRIx64 " %s:\n",
-- 
2.21.0




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux