On Wed, Apr 3, 2019 at 9:42 PM Jason Gunthorpe <jgg@xxxxxxxx> wrote:
>
> On Mon, Feb 25, 2019 at 08:56:14AM +0200, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> >
> > Refactor the page fault handler to be more readable and extensible,
> > this cleanup was triggered by error reported below. The code structure
> > made unclear to the automatic tools to identify that such flow is not
> > possible in real life because "requestor != NULL" means that "qp != NULL"
> > too.
> >
> > drivers/infiniband/hw/mlx5/odp.c:1254 mlx5_ib_mr_wqe_pfault_handler()
> > error: we previously assumed 'qp' could be null (see line 1230)
> >
> > Fixes: 08100fad5cac ("IB/mlx5: Add ODP SRQ support")
> > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > Reviewed-by: Moni Shoua <monis@xxxxxxxxxxxx>
> > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> > ---
> > Changes v0->v1:
> > * Instead of simple fix, rewrote whole function to be more clear.
> > ---
> > drivers/infiniband/hw/mlx5/odp.c | 121 ++++++++++++++-----------------
> > 1 file changed, 55 insertions(+), 66 deletions(-)
>
> Applied to for-next, with the extra 'else', thanks
Jason,
Please change "int ret;" to be "int ret = 0;" in this patch as we mentioned it.
Thanks
>
>
> Jason
