Re: [PATCH for-rc] RDMA/vmw_pvrdma: Fix memory leak on pvrdma_pci_remove

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/3/19 6:52 AM, Kamal Heib wrote:
> Make sure to free the DSR on pvrdma_pci_remove() to avoid the memory leak.
> 
> Fixes: 29c8d9eba550 ("IB: Add vmw_pvrdma driver")
> Signed-off-by: Kamal Heib <kamalheib1@xxxxxxxxx>

Oops! Thanks for the fix. Shouldn't this go to stable as well?

Acked-by: Adit Ranadive <aditr@xxxxxxxxxx>

> ---
>  drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
> index 6d8b3e0de57a..ec41400fec0c 100644
> --- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
> +++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
> @@ -1131,6 +1131,8 @@ static void pvrdma_pci_remove(struct pci_dev *pdev)
>  	pvrdma_page_dir_cleanup(dev, &dev->cq_pdir);
>  	pvrdma_page_dir_cleanup(dev, &dev->async_pdir);
>  	pvrdma_free_slots(dev);
> +	dma_free_coherent(&pdev->dev, sizeof(*dev->dsr), dev->dsr,
> +			  dev->dsrbase);
>  
>  	iounmap(dev->regs);
>  	kfree(dev->sgid_tbl);
> 





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux