On Sat, 2019-03-30 at 08:08 +0000, Leon Romanovsky wrote:
> On Fri, Mar 29, 2019 at 03:37:58PM -0700, Saeed Mahameed wrote:
> > From: Huy Nguyen <huyn@xxxxxxxxxxxx>
> >
> > Detach mlx5_core mdev messages from pci device mdev->pdev messages
> > and
> > provide a better report/debug of different mlx5 device types.
> >
> > This patch does not change any functionality.
> >
> > Signed-off-by: Huy Nguyen <huyn@xxxxxxxxxxxx>
> > Signed-off-by: Vu Pham <vuhuong@xxxxxxxxxxxx>
> > Signed-off-by: Saeed Mahameed <saeedm@xxxxxxxxxxxx>
> > ---
> > .../ethernet/mellanox/mlx5/core/mlx5_core.h | 19 +++++++++----
> > ------
> > 1 file changed, 9 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h
> > b/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h
> > index 7b331674622c..052e81974c3b 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h
> > @@ -48,12 +48,12 @@
> > extern uint mlx5_core_debug_mask;
> >
> > #define mlx5_core_dbg(__dev, format, ...)
> > \
> > - dev_dbg(&(__dev)->pdev->dev, "%s:%d:(pid %d): " format,
> > \
> > + pr_debug("%s:%s:%d:(pid %d): " format, (__dev)-
> > >priv.name, \
> > __func__, __LINE__, current->pid, \
>
> I see that we printed PID even before this patch, but unfortunately
> it
> is wrong and doesn't handle correctly kernel contexts.
>
> If you are changing those debug prints, it will be nicer to use
> CONFIG_PRINTK_CALLER instead like we are doing for the timestamps.
>
> https://marc.info/?l=linux-rdma&m=155289145403897&w=2
>
Cool, i will defer this to a future work, since it is going to be a
bigger change.
> Thanks
