> -----Original Message----- > From: Gal Pressman <galpress@xxxxxxxxxx> > Sent: Thursday, March 28, 2019 7:39 AM > To: Jason Gunthorpe <jgg@xxxxxxxx>; Doug Ledford <dledford@xxxxxxxxxx> > Cc: Yossi Leybovich <sleybo@xxxxxxxxxx>; Alexander Matushevsky > <matua@xxxxxxxxxx>; Leah Shalev <shalevl@xxxxxxxxxx>; Dave Goodell > <goodell@xxxxxxxxxx>; Brian Barrett <bbarrett@xxxxxxxxxx>; linux- > rdma@xxxxxxxxxxxxxxx; Sean Hefty <sean.hefty@xxxxxxxxx>; Dennis > Dalessandro <dennis.dalessandro@xxxxxxxxx>; Leon Romanovsky > <leon@xxxxxxxxxx>; Christoph Hellwig <hch@xxxxxxxxxxxxx>; Parav Pandit > <parav@xxxxxxxxxxxx>; Sagi Grimberg <sagi@xxxxxxxxxxx>; Steve Wise > <larrystevenwise@xxxxxxxxx>; Shiraz Saleem <shiraz.saleem@xxxxxxxxx>; > Gal Pressman <galpress@xxxxxxxxxx>; Jason Baron <jbaron@xxxxxxxxxx> > Subject: [PATCH rdma-next v4 01/12] RDMA/core: Introduce RDMA > subsystem ibdev_* print functions > > Similarly to dev/netdev/etc printk helpers, add standard printk helpers for > the RDMA subsystem. > > Example output: > efa 0000:00:06.0 efa_0: Hello World! > efa_0: Hello World! (no parent device set) (NULL ib_device): Hello World! > (ibdev is NULL) > We are working on mdev devices whose device name in kernel defined as 36 letters.. (standard uuid based) which is too long. Parent device visibility is already present at the sysfs level. Additionally with Leon's work on persistent device naming, ib device names are also going to be longer than current. Log will have more non-useful (long parent device name) information on every log entry. So we should just have ib_dev name and drop printing redundant parent device in this helper.
