Re: [PATCH 22/32] hfi1: Convert vesw_idr to XArray

Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx> · Mon, 1 Apr 2019 09:44:24 -0400

On 2/20/2019 7:20 PM, Matthew Wilcox wrote:
Signed-off-by: Matthew Wilcox <willy@xxxxxxxxxxxxx>
---
  drivers/infiniband/hw/hfi1/hfi.h       |  3 +--
  drivers/infiniband/hw/hfi1/vnic_main.c | 15 +++++++--------
  2 files changed, 8 insertions(+), 10 deletions(-)

.
.
.

diff --git a/drivers/infiniband/hw/hfi1/vnic_main.c b/drivers/infiniband/hw/hfi1/vnic_main.c
index a922db58be14..de40a03cddad 100644
--- a/drivers/infiniband/hw/hfi1/vnic_main.c
+++ b/drivers/infiniband/hw/hfi1/vnic_main.c
@@ -162,12 +162,11 @@ static void deallocate_vnic_ctxt(struct hfi1_devdata *dd,
  
  void hfi1_vnic_setup(struct hfi1_devdata *dd)
  {
-	idr_init(&dd->vnic.vesw_idr);
+	xa_init(&dd->vnic.vesws);
  }
  
  void hfi1_vnic_cleanup(struct hfi1_devdata *dd)
  {
-	idr_destroy(&dd->vnic.vesw_idr);
  }

Shouldn't this function just get removed?

-Denny






