On 01-Apr-19 11:08, Leon Romanovsky wrote:
> On Thu, Mar 28, 2019 at 02:39:23PM +0200, Gal Pressman wrote:
>> EFA PCIe device implements a single Admin Queue (AQ) and Admin Completion Queue
>> (ACQ) pair to initialize and communicate configuration with the device.
>> Through this pair, we run set/get commands for querying and configuring the
>> device, create/modify/destroy queues, and IB specific commands like Address
>> Handler (AH), Memory Registration (MR) and Protection Domains (PD).
>>
>> In addition to admin (AQ/ACQ), we have data path queues that get classified as
>> Queue Pairs (QP) and Completion Queues (CQ).
>>
>> Signed-off-by: Gal Pressman <galpress@xxxxxxxxxx>
>> Reviewed-by: Shiraz Saleem <shiraz.saleem@xxxxxxxxx>
>> Reviewed-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
>> ---
>> drivers/infiniband/hw/efa/efa_admin_cmds_defs.h | 796 ++++++++++++++++++++++++
>> drivers/infiniband/hw/efa/efa_admin_defs.h | 136 ++++
>> drivers/infiniband/hw/efa/efa_common_defs.h | 18 +
>> drivers/infiniband/hw/efa/efa_regs_defs.h | 113 ++++
>> 4 files changed, 1063 insertions(+)
>> create mode 100644 drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
>> create mode 100644 drivers/infiniband/hw/efa/efa_admin_defs.h
>> create mode 100644 drivers/infiniband/hw/efa/efa_common_defs.h
>> create mode 100644 drivers/infiniband/hw/efa/efa_regs_defs.h
>>
>> diff --git a/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h b/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
>> new file mode 100644
>> index 000000000000..ea2de3897bd6
>> --- /dev/null
>> +++ b/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
>> @@ -0,0 +1,796 @@
>> +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */
>> +/*
>> + * Copyright 2018-2019 Amazon.com, Inc. or its affiliates. All rights reserved.
>> + */
>> +
>> +#ifndef _EFA_ADMIN_CMDS_H_
>> +#define _EFA_ADMIN_CMDS_H_
>> +
>> +#define EFA_ADMIN_API_VERSION_MAJOR 0
>> +#define EFA_ADMIN_API_VERSION_MINOR 1
>> +
>> +/* EFA admin queue opcodes */
>> +enum efa_admin_aq_opcode {
>> + /* starting opcode of efa admin commands */
>> + EFA_ADMIN_START_CMD_RANGE = 1,
>> + EFA_ADMIN_CREATE_QP = EFA_ADMIN_START_CMD_RANGE,
>
> You are not using this EFA_ADMIN_START_CMD_RANGE in your submitted code.
Wanted to emphasize the fact that the opcodes start at one instead of zero, will
remove.
