On Tue, 2019-03-26 at 10:24 +-0000, Leon Romanovsky wrote: +AD4 On Thu, Mar 21, 2019 at 10:24:13AM -0700, Bart Van Assche wrote: +AD4 +AD4 This patch avoids that sparse complains about a missing declaration when +AD4 +AD4 building with CONFIG+AF8-MLX5+AF8-ESWITCH+AD0-n. +AD4 +AD4 What error do you see? +AD4 I'm building without MLX5+AF8-ESWITCH too and not fully understand what +AD4 declaration is missing. Hi Leon, sparse reports the following warning if I build with MLX5+AF8-ESWITCH disabled: drivers/infiniband/hw/mlx5/main.c:6486:30: warning: symbol 'uplink+AF8-rep+AF8-profile' was not declared. Should it be static? I think that is related to the following declaration in ib+AF8-rep.h: +ACM-ifdef CONFIG+AF8-MLX5+AF8-ESWITCH extern const struct mlx5+AF8-ib+AF8-profile uplink+AF8-rep+AF8-profile+ADs +AFs ... +AF0 +ACM-else +AFs ... +AF0 +ACM-endif Bart.
